Datepicker: Support parsing, formatting, and selecting four-digit years before year 100#1908
Open
wartmanm wants to merge 4 commits intojquery:mainfrom
Open
Datepicker: Support parsing, formatting, and selecting four-digit years before year 100#1908wartmanm wants to merge 4 commits intojquery:mainfrom
wartmanm wants to merge 4 commits intojquery:mainfrom
Conversation
4-digit years, unix times, and windows times now handle years between 0 and 99. Additionally, negative unix times can be parsed.
Fixes #7098
|
|
wartmanm
commented
Jan 23, 2020
| _formatYear: function( year ) { | ||
| var yearString = "" + year; | ||
| return year < 0 ? yearString : | ||
| yearString.length < 4 ? ( "0000" + yearString ).slice( -4 ) : yearString; |
Author
There was a problem hiding this comment.
I'm honestly not sure how negative dates should be formatted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes should resolve https://bugs.jqueryui.com/ticket/7098, as well as improving formatting for years before 1000.